This repository has been archived by the owner on Jun 2, 2020. It is now read-only.
default_config explicitly unset dnsmasq #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Ilario! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with OpenWrt 18.06, the current
configs/default_configworks perfectly well.But I tried to use the same configuration for compiling on OpenWrt trunk and it fails due to
dnsmasqbeing selected by default.I didn't manage to get why in trunk
dnsmasqgets selected by default while this does not happen in 18.06.Anyway explicitly deselecting it in
configs/default_configsolves for trunk and does not cause any harm on 18.06.