Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support alternative_select_labels config #13

Merged
merged 3 commits into from
Jun 3, 2023

Conversation

bczhc
Copy link
Contributor

@bczhc bczhc commented Jun 2, 2023

Hi! As #12 mentioned, alternative_select_labels hasn't been supported, then I added some code to achieve it. But so far I don't know how to write the test for it 😅

Fixes #12

@bczhc
Copy link
Contributor Author

bczhc commented Jun 2, 2023

Oops. Why does the CI fail?

@eagleoflqj
Copy link
Member

The artifact isn’t uploaded. Must be my misconfiguring CI script. Will take a look tomorrow.

Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear implementation!
A test is needed but I'll take care of it.

@eagleoflqj eagleoflqj merged commit d46f3ab into LibreService:master Jun 3, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持alternative_select_labelspage_size
2 participants