Bump package

Signed-off-by: Vitor Mattos <vitor@php.rio>
LibreSign · Apr 11, 2023 · f6798af · f6798af
1 parent 5796050
commit f6798af
Show file tree

Hide file tree

Showing 6 changed files with 250 additions and 519 deletions.
diff --git a/.github/workflows/behat.yml b/.github/workflows/behat.yml
@@ -50,6 +50,10 @@ jobs:
         env:
           MYSQL_ROOT_PASSWORD: rootpassword
         options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 5
+      mailhog:
+        image: mailhog/mailhog
+        ports:
+          - 8025:8025
 
     steps:
       - name: Checkout server
@@ -108,9 +112,11 @@ jobs:
             --admin-user=admin \
             --admin-pass=admin
           ./occ app:enable ${{ env.APP_NAME }}
+          ./occ config:system:set mail_smtpport --value 8025 --type integer
+          ./occ config:system:set mail_smtphost --value 127.0.0.1
 
       - name: Run behat
         working-directory: apps/${{ env.APP_NAME }}/tests/integration
         env:
           BEHAT_ROOT_DIR: ../../../../
-        run: vendor/bin/behat -f junit -f pretty --colors
+        run: vendor/bin/behat -f junit -f pretty --colors -v
diff --git a/lib/Helper/ValidateHelper.php b/lib/Helper/ValidateHelper.php
@@ -118,7 +118,7 @@ public function validateFile(array $data, int $type = self::TYPE_TO_SIGN): void
 			return;
 		}
 		if (empty($data['file']['url']) && empty($data['file']['base64']) && empty($data['file']['fileId'])) {
-			throw new LibresignException($this->l10n->t('File type: %s. Inform URL or base64 or fileID.', [$this->getTypeOfFile($type)]));
+			throw new LibresignException($this->l10n->t('File type: %s. Specify a URL, a base64 string or a fileID.', [$this->getTypeOfFile($type)]));
 		}
 		if (!empty($data['file']['fileId'])) {
 			if (!is_numeric($data['file']['fileId'])) {

diff --git a/lib/Migration/Version8000Date20230402103824.php b/lib/Migration/Version8000Date20230402103824.php
@@ -35,7 +35,7 @@
 class Version8000Date20230402103824 extends SimpleMigrationStep {
 	/**
 	 * @param IOutput $output
-	 * @param Closure(): ISchemaWrapper $schemaClosure
+	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
 	 * @param array $options
 	 * @return null|ISchemaWrapper
 	 */

diff --git a/tests/Unit/Helper/ValidateHelperTest.php b/tests/Unit/Helper/ValidateHelperTest.php
@@ -88,7 +88,7 @@ private function getValidateHelper(): ValidateHelper {
 	}
 
 	public function testValidateFileWithoutAllNecessaryData() {
-		$this->expectExceptionMessage('File type: %s. Inform URL or base64 or fileID.');
+		$this->expectExceptionMessage('File type: %s. Specify a URL, a base64 string or a fileID.');
 		$this->getValidateHelper()->validateFile([
 			'file' => ['invalid'],
 			'name' => 'test'

diff --git a/tests/integration/composer.json b/tests/integration/composer.json
@@ -7,6 +7,6 @@
     },
     "require-dev": {
         "libresign/behat-builtin-extension": "^0.4.3",
-        "libresign/nextcloud-behat": "^0.3.0"
+        "libresign/nextcloud-behat": "^0.5.0"
     }
 }