Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable page preview #2027

Merged
merged 6 commits into from
Dec 28, 2023
Merged

Disable page preview #2027

merged 6 commits into from
Dec 28, 2023

Conversation

vitormattos
Copy link
Member

@vitormattos vitormattos commented Dec 27, 2023

The default behavior is disabled.

To enable will be necessary run an occ command, but I think that we don't will need this code.

@vitormattos vitormattos force-pushed the feature/disable-page-preview branch 3 times, most recently from 7325839 to 9b16710 Compare December 27, 2023 16:03
@vitormattos vitormattos self-assigned this Dec 27, 2023
lib/Command/Configure/Check.php Outdated Show resolved Hide resolved
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
I undesrtood that is important to run the command but I removed this
logic to reduce the IO

Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos
Copy link
Member Author

/backport to stable28

@vitormattos vitormattos merged commit e7fab72 into main Dec 28, 2023
37 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/disable-page-preview branch December 28, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants