Fix script crash and incomplete script menu on Windows

src/app/script/script_menu.cpp

@@ -27,14 +27,14 @@ using namespace ui;
 
 void scanFolder(const std::string& scriptsDir, Command* cmd_run_script, Menu* parent) {
   auto fs = FileSystemModule::instance();
-  auto item = fs->getFileItemFromPath(scriptsDir);
+  auto item = fs->getFileItemFromPath(base::fix_path_separators(scriptsDir));
   if (!item)
     return;
   Params params;
   FileItemList list = item->children();
   for (auto child : list) {
     bool isFolder = child->isFolder();
-    std::string fullPath = base::fix_path_separators(child->fileName());
+    std::string fullPath = child->fileName();
     if (!isFolder) {
       bool supported = false;
       auto extension = base::string_to_lower(base::get_file_extension(fullPath));

src/script/v8/engine.cpp

@@ -5,7 +5,6 @@
 // Read LICENSE.txt for more information.
 
 
-#include <cstring>
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
@@ -19,6 +18,8 @@
 #include "script/engine.h"
 #include "script/engine_delegate.h"
 
+#include "app/resource_finder.h"
+#include <cstring>
 #include <map>
 #include <iostream>
 #include <string>
@@ -59,10 +60,13 @@ class V8Engine : public Engine {
   void initV8() {
     static std::unique_ptr<v8::Platform> m_platform;
     if (!m_platform) {
-      // Conflicting documentation. Not sure if this is actually needed.
-      // v8::V8::InitializeICUDefaultLocation(base::get_app_path().c_str());
-      // v8::V8::InitializeExternalStartupData(base::get_app_path().c_str());
-      v8::V8::InitializeICU();
+      app::ResourceFinder rf;
+      rf.includeBinDir("snapshot_blob.bin");
+      if (rf.findFirst()) {
+	v8::V8::InitializeExternalStartupData(rf.filename().c_str());
+      } else {
+	v8::V8::InitializeICU();
+      }
 
       m_platform = v8::platform::NewDefaultPlatform();
       v8::V8::InitializePlatform(m_platform.get());