Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Status Page does not support purely systemd units #662

Closed
paddatrapper opened this issue Dec 24, 2018 · 7 comments · Fixed by #997
Closed

Problem: Status Page does not support purely systemd units #662

paddatrapper opened this issue Dec 24, 2018 · 7 comments · Fixed by #997
Assignees
Labels
installer This is affecting the installer is: bug setup
Milestone

Comments

@paddatrapper
Copy link
Contributor

paddatrapper commented Dec 24, 2018

Describe the bug
Installing airtime_analyzer, airtime-liquidsoap and airtime-playout using systemd units (with no files in /etc/init.d) and not having initctl installed results in the configuration checklist thinking that the services are not running, when they actually are (as verified using systemctl status).

To Reproduce
Steps to reproduce the behavior:

  1. Install the deb
  2. Step through installer
  3. Verify running status of services

Expected behavior
The configuration checklist reports that they are running (and that they are actually running)

LibreTime version:
3.0.0-alpha.6

Installation method:

  • OS: Ubuntu
  • OS Version: 16.04.5 LTS (Xenial Xerus)]
  • Method: deb package
@hairmare
Copy link
Member

hairmare commented Dec 24, 2018

This also affects the status page under settings which calls the same code.

I've been ignoring the checklist in my rpm based installations since they have the same problem. I've started to think about solving this issue by asking the system dbus directly (and allowing that through polkit) but haven't gone down that route since it's quite a piece of work. The last time I checked we still supported some pre systemd distros. I don't think any of the remaining distros will not be based on systemd once we drop support for Ubuntu Trusty so I've been holding off on implementing anything until then.

On production I usually skip the whole configuration checklist thing because I create the conf manually.

@Robbt Robbt added installer This is affecting the installer setup release-blocker labels Jan 18, 2019
@Robbt Robbt added this to the 3.0.0 milestone Jan 18, 2019
@hairmare
Copy link
Member

Now that Ubuntu Trusty is off the tables it looks like all of our distros support systemd as default init system. We might consider just deferring to something like Cockpit to cover this need and mostly remove the status functionality. I would like to keep the status page to some extent so embedding cockpit could be a solution.

@paddatrapper
Copy link
Contributor Author

The problem with embedding cockpit is that it makes packaging a nightmare... At least in Debian, I would need to patch the embedded link out

@Robbt
Copy link
Member

Robbt commented Jul 16, 2019

I see that Cockpit packages are in Debian Buster - https://packages.debian.org/buster/cockpit - are these too old to be compatible ? I think that embedding it would just be integrating a iframe to cockpit that is running elsewhere, so it would be no different than how we use Icecast etc. I certainly understand the concern if we were treating it like a jquery library etc but if we just do the simple integration and install the packages independent of the files it doesn't seem like it would introduce any problems. It might be overkill in comparison to what we have now but it might not.

I think in some ways it would be cool if we had opt-in crash and statistic reporting but considering the amount of bugs we already have open we are not lacking for bugs to fix.

@paddatrapper
Copy link
Contributor Author

Ah yes, sorry I seemed to fail to find that package when I was searching through. So if we depend on cockpit and set it up on the same server, it is fine in terms of Debian policy. Connecting to a hard-coded remote instance would be more of an issue.

It is certainly overkill compared to what we have now, but we may be able to integrate it to do things like automatically restart the systemd units after the setup wizard

@dave31610
Copy link
Contributor

hi how can i solve the problem i can't figure it out and i don't know how to get it right

@paddatrapper
Copy link
Contributor Author

So it seems that the configuration checklist reports things correctly, however the status page in LibreTime does not (testing on vagrant Debian Buster box)

@paddatrapper paddatrapper changed the title Problem: Configuration Checklist does not support purely systemd units Problem: Status Page does not support purely systemd units Jan 8, 2020
@Robbt Robbt self-assigned this Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installer This is affecting the installer is: bug setup
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants