Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced weekly widget [WIP] #443

Closed
wants to merge 2 commits into from
Closed

Enhanced weekly widget [WIP] #443

wants to merge 2 commits into from

Conversation

JohnnyC1951
Copy link

Adds Show Logo, Description and Show URL link and adds abbreviated timezone to show times (avoids confusion across time-zones).
screenshot from 2018-02-11 01-36-37
screenshot from 2018-02-11 01-35-38

@JohnnyC1951
Copy link
Author

I think I doubled up by mistake :( sorry.

@korotkov13
Copy link

korotkov13 commented Feb 11, 2018

It's cool feature. I waited so long for it.
I tried it, and found one inconvenience. If I upload a picture(300x300 or other size) it shows full sized in widget. It would be cool if all the pics would be resized automatically to page resolution.
I don't know how to make it. It is just users feedback.
Thanks again for your work.
upd:
one more thing: On desktop it shows very thin. on mobile phone it's ok. and if i press on the show it opens a new(same widget) window.

@JohnnyC1951
Copy link
Author

JohnnyC1951 commented Feb 11, 2018

@korotkov13
A revised version attached & footnotes.
I think the problem you had with the link was that you had no url defined in the show url.

Changes:

  1. It does not show or have any hyperlinks if the show url field is empty.
  2. The width of the show logo is now scaled to 80px wide.
  3. Other changes: reduced panel padding by 20px on each side
  4. There is inline css if you need to tweak stuff.
  5. Be aware that huge numbers of large logo images will slow down the page load.

I would have done another pull request, but I am not authorized to do that (it said when I tried).
weekly-program.phtml.zip

@korotkov13
Copy link

korotkov13 commented Feb 11, 2018

Thanks!
One more thing that I did not understand. how to change the time from 12 to 24 hours in format?
It's shows only in 12hours format

upd:
sorry my fault.
everything is working

@JohnnyC1951
Copy link
Author

JohnnyC1951 commented Feb 11, 2018

To force it (disable auto locale) change:

"show_start_hour": start_date.toLocaleTimeString([], { hour: 'numeric', minute : 'numeric' }),
"show_end_hour": end_date.toLocaleTimeString([], { hour: 'numeric', minute : 'numeric' }),

To: (or other locale that uses the 24hr clock)

"show_start_hour": start_date.toLocaleTimeString(['en-GB'], { hour: 'numeric', minute : 'numeric' }),
"show_end_hour": end_date.toLocaleTimeString(['en-GB'], { hour: 'numeric', minute : 'n

@JohnnyC1951
Copy link
Author

All new version coming very soon. Please do not merge this.

@Robbt
Copy link
Member

Robbt commented May 10, 2018

Ok, the convention is to add [WIP] to the title this will prevent merges. I'll do that for you. Edit the title and remove the [WIP] when it's been updated. Thanks.

@Robbt Robbt changed the title Enhanced weekly widget Enhanced weekly widget [WIP] May 10, 2018
@JohnnyC1951
Copy link
Author

Thanks Robbt. I had no idea. I had been looking to cancel it somehow too.

@stale
Copy link

stale bot commented Oct 20, 2019

This issue has been automatically marked as stale because it has not had activity in the last 5 months. It will be closed if no activity occurs in the next month.
Please chat to us on discourse or ask for help on our chat if you have any questions or need further support with getting this issue resolved.
You may also label an issue as pinned if you would like to make sure that it does not get closed by this bot.

@stale stale bot added the status: stalled This issue or pull request is stalled label Oct 20, 2019
@stale
Copy link

stale bot commented Nov 19, 2019

This issue has been autmatically closed after is was marked as stale and did not receive any further inputs.
Feel free to let us know on discourse or ask for help on our chat if you feel this issue should not have been closed.
Thank you for your contributions.

@stale stale bot closed this Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: stalled This issue or pull request is stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants