Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app->libretranslate; mv tests/ inside libretranslate/ #372

Merged
merged 1 commit into from
Dec 30, 2022
Merged

app->libretranslate; mv tests/ inside libretranslate/ #372

merged 1 commit into from
Dec 30, 2022

Conversation

reynoldsnlp
Copy link
Contributor

fixes #371

@reynoldsnlp
Copy link
Contributor Author

I moved tests/ inside the libretranslate module, so they would not be installed as their own module. Another approach would be to leave the tests/ dir in the root dir, but to delete the tests/__init__.py files.

pierotofy
pierotofy approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@pierotofy pierotofy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improved directory/module structure @reynoldsnlp, this looks great!

@pierotofy pierotofy merged commit 033554a into LibreTranslate:main Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierotofy pierotofy pierotofy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip install makes app module (not libretranslate)
2 participants
@reynoldsnlp @pierotofy