Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the github root less cluttered. #391

Merged
merged 18 commits into from
Jan 13, 2023
Merged

Make the github root less cluttered. #391

merged 18 commits into from
Jan 13, 2023

Conversation

dingedi
Copy link
Collaborator

@dingedi dingedi commented Jan 12, 2023

there have been quite a few miscellaneous scripts added to the root of the github and there are a lot of files, which makes it a bit more complicated to understand the project and which files are needed because some scripts are very specific.

  • Migrate various scripts in a "scripts" folder
  • Put the dockerfile in a .docker folder

@pierotofy
Copy link
Member

Good idea; just careful with the scripts, they might need to be tested to make sure they work once they've been moved.

@dingedi
Copy link
Collaborator Author

dingedi commented Jan 12, 2023

yes I will recheck, I wanted to see if the CI tests passed

for the scripts for windows .bat I don't have a windows pc if someone can have that checked

@pierotofy
Copy link
Member

pierotofy commented Jan 12, 2023

I would leave run.sh and run.bat in the root. These are the first commands a person might run when using LT with docker.

@dingedi
Copy link
Collaborator Author

dingedi commented Jan 12, 2023

Checked scripts:

  • compile_locales.py
  • gunicorn_conf.py
  • install_models.py
  • suggestions-to-jsonl.py
  • update_locales.py

@dingedi
Copy link
Collaborator Author

dingedi commented Jan 12, 2023

I checked the scripts and all seem to work fine.

only suggestions-to-jsonl didn't work but it's not related to my PR, it doesn't work anymore also in main since the suggestions.db is in the db folder and the default path wasn't changed, I got it corrected

@pierotofy
Copy link
Member

Is this good to be reviewed/merged?

@dingedi
Copy link
Collaborator Author

dingedi commented Jan 13, 2023

Is this good to be reviewed/merged?

Yes

@pierotofy
Copy link
Member

Looks good! I've made some minor tweaks, but everything else worked great. Thanks @dingedi

@pierotofy pierotofy merged commit ad1fbcd into LibreTranslate:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants