Use lingua for language detection #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps by attempting to identify the words from a dictionary. |
|
Fixes #352 |
|
We now use a hybrid lingua + https://github.com/LibreTranslate/LexiLang for doing language detection. Seems like a good improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces PyCLD2 with lingua (via linguars). It seems to work quite better for long texts (>20 characters), but struggles just like the others for shorter texts, as others have highlighted before.
It also comes with a severe runtime penalty, as it's a magnitude slower than PyCLD2. I'm not too inclined to merge this right away, at least until I have a solution to improving short texts as well.