Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ltmanage in bin #580

Merged
merged 2 commits into from Jan 25, 2024
Merged

ltmanage in bin #580

merged 2 commits into from Jan 25, 2024

Conversation

jmlord
Copy link
Contributor

@jmlord jmlord commented Jan 24, 2024

This allows using the API key instructions from the read-me "as-is" in the docker container.
See also https://community.libretranslate.com/t/where-do-i-find-ltmanage-command/406

I also corrected the path to the keys db in the docker compose file comments, otherwise it did not work in my setup:
libretranslate_api_keys:/app/db/api_keys.db -> libretranslate_api_keys:/app/db

Tests: For some reason, on my localhost, the api-keys option did not block requests done through the UI (event before my changes). So, I tested by rate-limiting users to 0/minute and creating an API key that allows 120/minute.

A similar setup could be done for cuda version.

This allows using the api key instructions from the readme as-is in the docker container.
Copy link
Member

@pierotofy pierotofy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @jmlord !

@pierotofy pierotofy merged commit b7a273d into LibreTranslate:main Jan 25, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants