New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make libretranslate works with ipv6 #596
Conversation
Thanks for the PR @cyrinux ! This will break access to ipv4 however; (0.0.0.0 will no longer be accessible). Waitress has a special "*" address for binding to both ipv4 and ipv6 (see https://docs.pylonsproject.org/projects/waitress/en/stable/usage.html). "*" will however not work when I would add a check near that line where "if debug and host == '*': then host = '0.0.0.0'". |
Hi @pierotofy , Ok, I will try to fix in that way. As far this is working, I though it would be ok too in python: What about the healthcheck so? We check both 127.0.0.1 and ::1 ? I will maybe just use http://localhost:5000 |
I push a new commit update, and choose to convert "*" to "::" for the debug mode, as "::" will make listen on both ipv4 and ipv6, is it ok for you @pierotofy ? |
Nice, yes that works. I think |
Thanks, sorry, I forgot to commit them. I just test a last time, on my ipv6 only cluster. Its OK for me. I will be happy if you merge and publish a new tag then 👍🏻 🤗 |
Looks great, thanks! |
This should still works with ipv4 then. Tested on a only ipv6 k8s cluster.