Skip to content

Commit

Permalink
Bug 7788: [SIGNED-OFF] Followup: GetShelf call in addbybiblio script …
Browse files Browse the repository at this point in the history
…corrected

Patch resolves incorrect call to GetShelf in opac and staff. It was and is harmless, because the singlecategory variable was not really used (the category$x param was ignored in the template). Just a cleanup operation.

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
  • Loading branch information
mderooy authored and PaulPoulain committed May 22, 2012
1 parent 6636d69 commit 3945ecf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions opac/opac-addbybiblionumber.pl
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,11 @@ sub HandleShelfNumber {
sub HandleSelectedShelf {
if($authorized= ShelfPossibleAction( $loggedinuser, $selectedshelf, 'add')){
#adding to specific shelf
my ($singleshelf, $singleshelfname, $singlecategory)= GetShelf($query->param('selectedshelf'));
my ($singleshelf, $singleshelfname)= GetShelf($query->param('selectedshelf'));
$template->param(
singleshelf => 1,
shelfnumber => $singleshelf,
shelfname => $singleshelfname,
"category$singlecategory" => 1
);
}
}
Expand Down
3 changes: 1 addition & 2 deletions virtualshelves/addbybiblionumber.pl
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,11 @@ sub HandleShelfNumber {
sub HandleSelectedShelf {
if($authorized= ShelfPossibleAction( $loggedinuser, $shelfnumber, 'add')){
#confirm adding to specific shelf
my ($singleshelf, $singleshelfname, $singlecategory)= GetShelf($shelfnumber);
my ($singleshelf, $singleshelfname)= GetShelf($shelfnumber);
$template->param(
singleshelf => 1,
shelfnumber => $singleshelf,
shelfname => $singleshelfname,
"category$singlecategory" => 1
);
}
else {
Expand Down

0 comments on commit 3945ecf

Please sign in to comment.