WIP - initial gdpr erase command. #375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioparaskev
reviewed
Apr 14, 2021
| @@ -688,7 +688,8 @@ def lone_view(self, round_number=None, team_number=None): | |||
|
|
|||
| class ICalPlayerView(BaseView, ICalMixin): | |||
| def view(self, username): | |||
| player = get_object_or_404(Player, lichess_username__iexact=username) | |||
| player = get_object_or_404( | |||
| Player, lichess_username__iexact=username, gdpr_erased=False) | |||
There was a problem hiding this comment.
since the players information will be scrubbed, do we need this filter? Why not get the player and have a hint that the information is gdpr scrubbed? (maybe it is a GDPR restriction that's why I'm asking :P)
There was a problem hiding this comment.
Because this page will list out all of the games they played and teams they were part of. This allows someone who is interested to work out who they were. The scrubbing is intended to stop that. So we made the decision to remove this page to make it harder to work out who they are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for merge yet, but I have some questions, so I thought I'd send it.