Fixed: Catch exceptions looking up fingerprints

It's not crucial so if it fails don't take out the whole import process.
Lidarr · Aug 29, 2019 · 91ddabe · 91ddabe
1 parent 2097bff
commit 91ddabe
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/NzbDrone.Core.Test/ParserTests/FingerprintingServiceFixture.cs b/src/NzbDrone.Core.Test/ParserTests/FingerprintingServiceFixture.cs
@@ -200,5 +200,19 @@ public void should_not_throw_if_api_returns_html()
 
             ExceptionVerification.ExpectedWarns(1);
         }
+
+        [Test]
+        public void should_not_throw_if_api_times_out()
+        {
+            Mocker.GetMock<IHttpClient>().Setup(x => x.Post<LookupResponse>(It.IsAny<HttpRequest>()))
+                .Throws(new System.Net.WebException("The operation has timed out."));
+
+            var path = Path.Combine(TestContext.CurrentContext.TestDirectory, "Files", "Media", "nin.mp3");
+            var localTrack = new LocalTrack { Path = path };
+            Subject.Lookup(new List<LocalTrack> { localTrack }, 0.5);
+            localTrack.AcoustIdResults.Should().BeNull();
+
+            ExceptionVerification.ExpectedWarns(1);
+        }
     }
 }
diff --git a/src/NzbDrone.Core/Parser/FingerprintingService.cs b/src/NzbDrone.Core/Parser/FingerprintingService.cs
@@ -375,6 +375,11 @@ public void Lookup(List<Tuple<LocalTrack, AcoustId>> files, double threshold)
                 _logger.Warn(e, "AcoustId API gave invalid response");
                 return;
             }
+            catch (Exception e)
+            {
+                _logger.Warn(e, "AcoustId API lookup failed");
+                return;
+            }
 
             var response = httpResponse.Resource;