Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed: Centralize version numbers #961

Merged
merged 2 commits into from Sep 8, 2019
Merged

Changed: Centralize version numbers #961

merged 2 commits into from Sep 8, 2019

Conversation

ta264
Copy link
Contributor

@ta264 ta264 commented Sep 5, 2019

Database Migration

NO

Description

Centralize on a single place to set version numbers

Qstick
Qstick previously approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@Qstick Qstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the packages generated, but code looks good

Qstick
Qstick reviewed Sep 7, 2019
View reviewed changes
Copy link
Contributor

@Qstick Qstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the package the info.plist didnt seem to get changed to build number.

@Qstick
Copy link
Contributor

Qstick commented Sep 7, 2019

Looks to work now, good unless you think there is a more elegant solution than running sed again in package.

@Qstick Qstick added the Area: Tooling Issue is related to tooling label Sep 7, 2019
@Qstick Qstick changed the title Centralize version numbers Changed: Centralize version numbers Sep 8, 2019
@Qstick Qstick merged commit a627c2c into develop Sep 8, 2019
@Qstick Qstick deleted the version-numbers branch September 8, 2019 00:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qstick Qstick Qstick approved these changes

Assignees
No one assigned
Labels
Area: Tooling Issue is related to tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ta264 @Qstick