Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding file attachments to scenario steps #255

Closed
adrian-herscu opened this issue Apr 18, 2022 · 2 comments
Closed

Adding file attachments to scenario steps #255

adrian-herscu opened this issue Apr 18, 2022 · 2 comments
Labels
enhancement An enhancement of the feature or new feature
Milestone
3.5.0

Comments

@adrian-herscu
Copy link

Description

Test reports should support attachment of screenshots or other text files as a proof of actual result(s) retrieved during tests' execution.

This feature can be found in other BDD frameworks.
@Suremaker Suremaker added the enhancement An enhancement of the feature or new feature label Apr 19, 2022
@Suremaker
Copy link
Collaborator

Hello @adrian-herscu ,

Thanks for raising this request. It makes sense and I will consider it when implementing #133 .

@Suremaker Suremaker added this to the 3.5.0 milestone Apr 19, 2022
@Suremaker Suremaker changed the title step attachments Adding file attachments to scenario steps Jun 26, 2022
@Suremaker
Copy link
Collaborator

Suremaker commented Jun 26, 2022 •
edited
Loading

Implementation progress

  • Mechanism to capture file attachments by the engine
  • Progress Notification of file attachment during test execution
  • Add file attachment links to text report
  • Add file attachment links to xml report
  • Add file attachment links to html report

Suremaker added a commit that referenced this issue Jun 26, 2022
@Suremaker
#255 Added support to attach files to steps with `StepExecution.Curre…
5fb96ee 
…nt.AttachFile`

Added progress notification when FileAttachment is created for the step
Suremaker added a commit that referenced this issue Jul 31, 2022
@Suremaker
#255 Expanded PlainTextReportFormatter and XmlReportFormatter to incl…
c795d07 
…ude FileAttachments
Suremaker added a commit that referenced this issue Jul 31, 2022
@Suremaker
#255 Reformatted attachments in html report
575a304
Suremaker added a commit that referenced this issue Jul 31, 2022
@Suremaker
#255 Updated examples to contain attachments
09df9a4 
Updated Changelog
Added FileAttachmentsManagerExtensions
@Suremaker Suremaker mentioned this issue Jul 31, 2022
Merged
5 tasks
Suremaker added a commit that referenced this issue Jul 31, 2022
@Suremaker
#255 Added support for file attachments on scenario steps (#262)
278e33e 
(LightBDD.Core) Added IStep.AttachFile() method allowing to add file attachments to steps and fired StepFileAttached progress notification event when attachment is made
(LightBDD.Core) Added ReportWritersConfiguration.UpdateFileAttachmentsManager() to allow re-configuring file attachments storage
(LightBDD.Framework) Added support to attach files to steps with StepExecution.Current.AttachFile()
(LightBDD.Framework) Added FileAttachmentManager implementation and registered it with ReportWritersConfiguration.RegisterDefaultFileAttachmentManager() extension method to create attachments in ~/Reports folder
(LightBDD.Framework) Updated DefaultProgressNotifier to notify on StepFileAttached event
(LightBDD.Framework) Updated HtmlResultTextWriter / PlainTextReportFormatter / XmlReportFormatter to include file attachments
@Suremaker Suremaker mentioned this issue Jul 31, 2022
Merged
5 tasks
Suremaker added a commit that referenced this issue Aug 7, 2022
@Suremaker
#255 Improved FileAttachmentManager to create directory upon first usage
ff89006
Suremaker added a commit that referenced this issue Aug 7, 2022
@Suremaker
#255 Improved DefaultProgressNotifier notification of file attachments
7e68161
Suremaker added a commit that referenced this issue Aug 7, 2022
@Suremaker
Release 3.5.0 (#263)
85aa481 
#260 (LightBDD.MsTest2)(Change) Updated MSTest.TestFramework to 2.2.10
#260 (LightBDD.NUnit3)(Change) Updated NUnit dependency to 3.13.3
#260 (LightBDD.Fixie2)(Change) Dropped netcoreapp2.0 support
#260 (Examples) Removed Example.LightBDD.MsTest2.UWP project as UWP is deprecated
#255 (LightBDD.Core) Added IStep.AttachFile() method allowing to add file attachments to steps and fired StepFileAttached progress notification event when attachment is made
#255 (LightBDD.Core) Added ReportWritersConfiguration.UpdateFileAttachmentsManager() to allow re-configuring file attachments storage
#255 (LightBDD.Framework) Added support to attach files to steps with StepExecution.Current.AttachFile()
#255 (LightBDD.Framework) Added FileAttachmentManager implementation and registered it with ReportWritersConfiguration.RegisterDefaultFileAttachmentManager() extension method to create attachments in ~/Reports folder
#255 (LightBDD.Framework) Updated DefaultProgressNotifier to notify on StepFileAttached event
#255 (LightBDD.Framework) Updated HtmlResultTextWriter / PlainTextReportFormatter / XmlReportFormatter to include file attachments
#225 (Core)(New) Introduced IProgressNotifier and processing events: FeatureStarting, FeatureFinished, ScenarioStarting, ScenarioFinished, StepStarting, StepFinished, StepCommented
#225 (Core)(New) Extended ScenarioExecutionContext with GetCurrentScenarioFixtureIfPresent to return fixture object executing given scenario
#225 (Framework)(New) Introduced ProgressNotifierConfiguration to configure IProgressNotifier instances and updated DefaultProgressNotifier, NoProgressNotifier to implement IProgressNotifier and added ParallelProgressNotifierProvider.CreateProgressNotifier() method
#225 (LightBDD.XUnit2/LightBDD.NUnit3/LightBDD.MsTest2/LightBDD.Fixie2)(Change) Updated projects to use IProgressNotifier configuration
#225 (Core/Framework)(Change) Obsoleted IScenarioProgressNotifier, IFeatureProgressNotifier, DelegatingScenarioProgressNotifier, DelegatingFeatureProgressNotifier and all methods using them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An enhancement of the feature or new feature
Projects
None yet
Milestone
3.5.0
Development

No branches or pull requests
2 participants
@Suremaker @adrian-herscu