Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Money type conversion #13

Open
wants to merge 139 commits into
base: master
Choose a base branch
from
Open

Money type conversion #13

wants to merge 139 commits into from

Conversation

cscederborg
Copy link
Contributor

@cscederborg cscederborg commented Aug 14, 2020 •
edited by sheesania

Depends on #39
Fixes #18

gbeeley and others added 25 commits August 7, 2020 11:50
@gbeeley
Sample money test
e17b356
@cscederborg
Merge branch 'money_type' of https://github.com/LightSys/centrallix i…
6995cb0 
…nto money_type
@cscederborg
A second set of test files to determine if I still appear as gbeeley …
c9313c8 
…when committing.
@cscederborg
Change MoneyType struct to contain a single long long instead of Whol…
2838eab 
…ePart/FractionPart
@cscederborg
Commenting out direct MoneyType usage in centrallix/utility
204f78b
@cscederborg
Commenting out direct MoneyType usage in centrallix/expression
4f3170d
@cscederborg
Commenting out direct MoneyType usage
016e2a7
@cscederborg
Converted obj_internal_FormatMoney to use the new 64 bit MoneyType
19d8480
@cscederborg
Converted objDataToDouble to new 64 bit MoneyType
114334d
@cscederborg
Converted objDataCompare to new 64 bit MoneyType
065399f
@cscederborg
Converted objDataToWords to new 64 bit MoneyType
c50ffc9
@cscederborg
Converted objDataToInteger to new 64 bit MoneyType
a04da49
@sheesania
Basic testrunner file for running arbitrary Centrallix functions
754bbf9
@cscederborg
Merge remote-tracking branch 'origin/money_type_testrunner' into mone…
ebeb912 
…y_type
@sheesania
Basic system for native C tests in /centrallix using assert
9c4b387
@sheesania
Display native C test output in blue
3db48cf
@sheesania
Removing old native C testing framework
713863a
@sheesania
Remove old temporary testrunner
50eea78
@sheesania
Update README
cfc6473
@sheesania
Update README for new direct C testing system
d7d4c14
@sheesania
Merge branch 'money_type_testrunner' of https://github.com/LightSys/c…
d9ef490 
…entrallix into money_type_testrunner
@sheesania
Remove extraneous name comments from old native C baselines
982068f
@sheesania
Example direct C test with assert and include
64a7451
@cscederborg
Converted objDataToMoney to 64 bit MoneyType representaion
c4fe742
@cscederborg
Updated functions that accounted for the unsigned nature of FractionPart
54c84cc
sheesania
sheesania reviewed Aug 14, 2020
View reviewed changes
centrallix-lib/include/datatypes.h Outdated Show resolved Hide resolved
centrallix/objectsystem/obj_datatypes.c Outdated Show resolved Hide resolved
centrallix/objectsystem/obj_datatypes.c Outdated Show resolved Hide resolved
centrallix/objectsystem/obj_datatypes.c Outdated Show resolved Hide resolved
centrallix/objectsystem/obj_datatypes.c Outdated Show resolved Hide resolved
centrallix/objectsystem/obj_datatypes.c Outdated Show resolved Hide resolved
centrallix/objectsystem/obj_datatypes.c Outdated Show resolved Hide resolved
centrallix/objectsystem/obj_datatypes.c Outdated Show resolved Hide resolved
centrallix/objectsystem/obj_datatypes.c Outdated Show resolved Hide resolved
centrallix/objectsystem/obj_datatypes.c Outdated Show resolved Hide resolved
@sheesania
Better test helper doc strings
a5420a0
@sheesania
Test for moneytype changes in exp_internal_DumpExpression_r
adca88d
@sheesania
Test comparing MoneyType expressions
d2149f9
@sheesania
Move conversion to old money representation for JSON into separate fu…
9eea437 
…nction to enable test.

However, even though most of the business logic is being tested now, nht_i_RestWriteAttrValue (or public callers) still is not tested at all. It would be trivially easy to test with mocks/stubs, but is quite complex to test otherwise, and so I judged that it wasn't worth it to spend a lot of time writing a complete test right now when we might be implementing a test framework with mocks/stubs relatively soon. Please, future me, save us from the screaming void.
@sheesania
Fix dbl_internal_ParseColumn for MoneyType + test
5b87af4
@sheesania
Small fixes and cleanup of objdrv_fp MoneyType test
cb8df45
@sheesania
Test for json > MoneyType parsing
dea8823
@sheesania
Tests for MoneyType round expressions
e8ec84d
@sheesania
Test MoneyType round behavior with no decimal places parameter
ad91c3b
@sheesania
Tests for MoneyType truncate expressions
e936ff3
@sheesania
Tests for MoneyType max expression
c64cf6e
@sheesania
Tests for MoneyType min expressions
79888de
@sheesania
Merge branch 'master' into money_type
5c817dc
@sheesania
Basic framework for Sybase -> MoneyType test
86f2f82
@sheesania
Tests for getting MoneyType from objdrv_sybase + simplification of ob…
5a528cd 
…jdrv_sybase logic
@sheesania sheesania marked this pull request as ready for review July 13, 2021 21:40
Base automatically changed from qprintf_ll_specifier to master July 19, 2021 21:11
@sheesania sheesania mentioned this pull request Jul 23, 2021
Open
gbeeley
gbeeley reviewed Feb 11, 2022
View reviewed changes
Copy link
Member

@gbeeley gbeeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finished looking over the files here, next step is to actually work with it in testing.

centrallix/expression/exp_evaluate.c Show resolved Hide resolved
centrallix/objectsystem/obj_datatypes.c Outdated Show resolved Hide resolved
@sheesania sheesania mentioned this pull request Feb 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheesania sheesania sheesania approved these changes

@gbeeley gbeeley gbeeley approved these changes

Assignees

@sheesania sheesania

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert server-side MoneyType to single long long
3 participants
@cscederborg @gbeeley @sheesania