Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

.jshintrc Support #3

Open
whitlockjc opened this issue Jan 9, 2014 · 6 comments
Open

.jshintrc Support #3

whitlockjc opened this issue Jan 9, 2014 · 6 comments

Comments

@whitlockjc
Copy link

JSHint supports using a file to hold your configuration. Whenever the jshint executable is invoked, you can either use the --config flag to point to the .jshintrc file or you can let jshint locate your .jshintrc file(s) based on the CWD where the executable was invoked. This is documented in the Configuration section of the JSHint Documentation. The idea would either be to fix where jshint is executed from so that jshint can work as it would from the CLI or we can update the :lt.plugins.jshint/jshint-options to allow for a workspace path or fully qualified path. Thoughts?

Typically I'd submit a pull request but I've not filed the paperwork to contribute and I'm not up to speed on ClojureScript just yet. I'll see if I can expedite these things if necessary.

@ibdknox
Copy link
Member

ibdknox commented Jan 9, 2014

FYI, our CA is just an online form, so that's wonderfully simple and fast :)

@whitlockjc
Copy link
Author

Done. Now I'll see how best to update the plugin to work. Based on your opinion, which of these solutions would you rather see? I'd much rather see jshint executed in the workspace that the file being linted since this allows jshint to do its business as if executed from the command line. Also, any pointers regarding your suggested approach would be appreciated.

@doxxx
Copy link

doxxx commented Jan 19, 2014

My preference would be for it to Just Work(tm) for a standard project layout where .jshintrc is in the root of the project.

@mdeboer
Copy link

mdeboer commented Mar 26, 2014

+! @doxxx

Would love to see this work, also make sure it has a go at reading "jshintConfig" from package.json as that's also an officially supported way of storing the configuration for JSHint.

@Armaklan
Copy link

+1 doxxx

@cldwalker
Copy link
Member

Just released a version of this plugin. Happy to take a pull for this. No CAs are needed with LightTable anymore

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants