Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Handle unresponsive event #2102

Open
illuzen opened this issue Jan 8, 2016 · 7 comments
Open

Handle unresponsive event #2102

illuzen opened this issue Jan 8, 2016 · 7 comments

Comments

@illuzen
Copy link

illuzen commented Jan 8, 2016

I love LightTable, but I'll be switching back to Sublime Text until this is fixed.

I'm using it on Mac OSX 10.10.5

Happens consistently, but only after about a day. I force quit, restart it and it works fine. Is troublesome when it does it while I'm working because I lose all my work since last save.

@cldwalker
Copy link
Member

Sorry to hear. Handling an unresponsive event is on my short list which would make the force quit less painful. I'll leave this open to look into this. The losing work sucks and will be covered by #1700

@cldwalker cldwalker changed the title After leaving on for a day or so, LT window goes white, unresponsive, have to force quit Handle unresponsive event Jan 9, 2016
@cldwalker
Copy link
Member

Looked into handling unresponsive event by adding the following before this line:

  window.on("unresponsive", function() {
    console.log("PWNED!");
    alert("HANG!");
    window.destroy();
  });

Didn't see it handled. Pull requests welcome until we can dig into this more

@kenny-evitt
Copy link
Contributor

@snakecharmer1024 I was curious if you are (or were) encountering the same thing I just ran into, but I just noticed the title change. My Light Table window is also (visibly) unresponsive and the entire window is blank (and gray):

screen shot 2016-01-10 at 2 02 32 pm

Activity Monitor reports the CPU Time of the process as 16:27. In 'realtime', I've had it open for at least a few days, tho I haven't been using it, or this computer, extensively. This is the first time I've run into this problem.

Activity Monitor also reports a "Virtual Memory Size" of 3.6 GB for the LT app process, which seems like it might be rather high. The "Electron Helper" process has a 2.5 GB virtual memory size.

I'm running OS X 10.11.2. I'm running a source build a few commits behind 0.8.0 (I think), but I don't expect any more-recent commits significantly affect this.

My log file is empty.

@kenny-evitt
Copy link
Contributor

It seems this is an open issue upstream with Electron – see electron/electron#2409.

I commented on that issue and linked to a Gist with my crash dump file contents. It looks like an out-of-memory issue, tho I can't tell if it's Node that's the culprit or if it's just handling the out-of-memory condition.

@kenny-evitt
Copy link
Contributor

@snakecharmer1024 If you would, please upload a crash dump (e.g. as a GitHub Gist or something similar) and link to it in a comment here and in electron/electron#2409. If you don't want to get bitten again by losing unsaved work, maybe it'd be sufficient just to open LT and leave it running, without actually using it.

@illuzen
Copy link
Author

illuzen commented Jan 11, 2016

@kenny-evitt Yes that is exactly what I saw. I'll leave it on and post the crash dump. Where do I find the crash dump, again?

@kenny-evitt
Copy link
Contributor

You might need to open the directory by running open . in Terminal, but I found mine in ~/Library/DiagnosticReport (I think). It's the Mac OS X standard location for crash dumps so Google should confirm if my memory is accurate.

That said, an Electron person replied to me on their issue and stated that LT is to blame in my case and that we should track down the likely memory leak on our end. So we should be running with Dev Inspector open and periodically checking memory usage (if that's not too much of a pain).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants