Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for React 16 & performance improve #29

Merged
merged 4 commits into from
Sep 4, 2017

Conversation

inDream
Copy link
Contributor

@inDream inDream commented Aug 3, 2017

Fix #22 #28
Merge changes from #20 #23
Added handle selection, currentTime changes
Improve performance by changing setGroups before setItems.

*For currentTime I change the window instead of currentTime to preserve the auto update behavior when init without currentTime and want to navigate to another date by changing currentTime.

@mouhsinelonly
Copy link

will this be merged soon

@harmon25
Copy link

any progress on merging these changes?
Fiber is ready!

@mouhsinelonly
Copy link

Can you please merge this

@jseminck
Copy link

jseminck commented Sep 1, 2017

I'd also like to see this merged. 👍

@willmcclellan
Copy link
Member

Apologies for the delay, we'll take a look at this on Monday and look to get it merged 👍

@jseminck
Copy link

jseminck commented Sep 1, 2017

Thanks. 😄 I'm hoping this change will decrease the bundle size because the whole vis is no longer imported, but just the graph2d part 🎉

@willmcclellan willmcclellan merged commit 6387280 into Lighthouse-io:master Sep 4, 2017
@willmcclellan
Copy link
Member

Merged and published on npm v1.4.0.

Thanks for this @inDream! Build size should reduce dramatically which is awesome because visjs is just a huge dependency 👏 👏 👏

This was referenced Sep 4, 2017
@jseminck
Copy link

jseminck commented Sep 4, 2017

Seems to be working fine 🎉 Here's a before and after of the dependency in our bundle:

screen shot 2017-09-04 at 10 46 49

screen shot 2017-09-04 at 10 43 54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants