Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid multiple get_event_loop calls #148

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Jun 20, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

minor async cleanup to avoid multiple get_event_loop calls

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80%. Comparing base (51b3358) to head (308ce6b).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #148   +/-   ##
===================================
  Coverage    80%    80%           
===================================
  Files        13     13           
  Lines       904    905    +1     
===================================
+ Hits        726    727    +1     
  Misses      178    178           

@lantiga lantiga merged commit ec05a06 into main Jun 20, 2024
19 checks passed
@lantiga lantiga deleted the aniket/minor-async-refactor branch June 20, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants