Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose before_ commands #11

Merged
merged 1 commit into from
Nov 29, 2021
Merged

expose before_ commands #11

merged 1 commit into from
Nov 29, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 29, 2021 •
edited

Before submitting

  • Was this discussed/approved via a GitHub issue? (no need for typos and docs improvements)
  • Did you create/update your configuration file?
  • Did you add your config to CI - GitHub action and Azure pipeline?
  • Are all integration tests passing?

What does this PR do? [optional]

Resolves #9
it shall unblock #7

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added the enhancement New feature or request label Nov 29, 2021
SeanNaren
SeanNaren approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SeanNaren SeanNaren enabled auto-merge (squash) November 29, 2021 16:24
@Borda Borda disabled auto-merge November 29, 2021 17:15
@Borda Borda merged commit 670119f into main Nov 29, 2021
@Borda Borda deleted the config/cmd branch November 29, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanNaren SeanNaren SeanNaren approved these changes

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expose other build commands
2 participants
@Borda @SeanNaren