Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow install's flags #75

Merged
merged 7 commits into from
Dec 6, 2022
Merged

allow install's flags #75

merged 7 commits into from
Dec 6, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 6, 2022

Before submitting

  • Was this discussed/approved via a GitHub issue? (no need for typos and docs improvements)
  • Did you create/update your configuration file?
  • Did you set runtimes in config for GitHub action integration?
  • Did you add your config to CI in Azure pipeline (only projects with 100+ GitHub stars)?
  • Are all integration tests passing?

What does this PR do? [optional]

Adding an option to specify install flags
it is needed for #71 and #72

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added the enhancement New feature or request label Dec 6, 2022
@Borda Borda marked this pull request as draft December 6, 2022 13:11
@Borda Borda self-assigned this Dec 6, 2022
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #75 (a18d750) into main (2f04fba) will decrease coverage by 1%.
The diff coverage is 81%.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #75   +/-   ##
==================================
- Coverage    86%   85%   -1%     
==================================
  Files         2     2           
  Lines       219   230   +11     
==================================
+ Hits        189   196    +7     
- Misses       30    34    +4     

@Borda Borda marked this pull request as ready for review December 6, 2022 14:22
actions/_config.yaml Outdated Show resolved Hide resolved
@Borda Borda merged commit 92dc701 into main Dec 6, 2022
@Borda Borda deleted the ci/install-flags branch December 6, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants