Decouple DataModules from Models - GAN

[nateraw]

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure to update the docs?
• Did you write any new necessary tests?

What does this PR do?

Partial fix of #207

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

[pep8speaks]

Hello @nateraw! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-11 21:08:52 UTC

[codecov]

Codecov Report

Merging #206 into master will decrease coverage by 0.09%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   89.23%   89.14%   -0.10%     
==========================================
  Files          74       74              
  Lines        3298     3297       -1     
==========================================
- Hits         2943     2939       -4     
- Misses        355      358       +3     

Flag	Coverage Δ
#unittests	89.14% <82.60%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pl_bolts/models/gans/basic/basic_gan_module.py	95.50% <81.81%> (-2.25%)	⬇️
..._bolts/models/self_supervised/moco/moco2_module.py	80.15% <100.00%> (ø)
pl_bolts/datamodules/async_dataloader.py	20.00% <0.00%> (-1.22%)	⬇️
...ts/models/autoencoders/basic_ae/basic_ae_module.py	85.71% <0.00%> (-1.06%)	⬇️
pl_bolts/models/detection/faster_rcnn.py	78.84% <0.00%> (-0.79%)	⬇️
pl_bolts/datamodules/__init__.py	100.00% <0.00%> (ø)
pl_bolts/callbacks/self_supervised.py	100.00% <0.00%> (ø)
pl_bolts/models/self_supervised/byol/models.py	100.00% <0.00%> (ø)
pl_bolts/models/regression/linear_regression.py	100.00% <0.00%> (ø)
pl_bolts/models/self_supervised/ssl_finetuner.py	34.21% <0.00%> (ø)
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850db3d...fc52839. Read the comment docs.