Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update arguments of GAN #333

Merged

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Nov 3, 2020

What does this PR do?

Fixes docs for GAN which was not updated in #206.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #333 into master will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   82.04%   82.24%   +0.20%     
==========================================
  Files          98       98              
  Lines        5492     5492              
==========================================
+ Hits         4506     4517      +11     
+ Misses        986      975      -11     
Flag Coverage Δ
cpu 24.24% <ø> (ø)
pytest 24.24% <ø> (ø)
unittests 81.62% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/models/gans/basic/basic_gan_module.py 95.34% <ø> (ø)
...l_bolts/models/rl/vanilla_policy_gradient_model.py 94.64% <0.00%> (+2.67%) ⬆️
pl_bolts/optimizers/lars_scheduling.py 95.74% <0.00%> (+17.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4e6096...27db516. Read the comment docs.

@akihironitta akihironitta changed the title [WIP] docs: Remove datamodule and data_dir from GAN docs: Update arguments of GAN Nov 3, 2020
@akihironitta akihironitta marked this pull request as ready for review November 3, 2020 22:55
@Borda Borda added the documentation Improvements or additions to documentation label Nov 6, 2020
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@Borda Borda merged commit a6bc807 into Lightning-Universe:master Nov 6, 2020
@Borda Borda added this to Done in AE & GANs Nov 20, 2020
@Borda Borda added this to the v0.3 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants