Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_review flag #835

Merged
merged 14 commits into from Jul 20, 2022
Merged

to_review flag #835

merged 14 commits into from Jul 20, 2022

Conversation

otaj
Copy link
Contributor

@otaj otaj commented Jul 19, 2022

What does this PR do?

This is the first step in reviving Bolts as outlined on Slack and #819 (comment)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added callback datamodule Anything related to datamodules documentation Improvements or additions to documentation model labels Jul 19, 2022
Borda
Borda approved these changes Jul 19, 2022
View reviewed changes
pl_bolts/utils/stability.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Jul 19, 2022
@mergify mergify bot requested a review from akihironitta as a code owner July 20, 2022 06:53
akihironitta
akihironitta approved these changes Jul 20, 2022
View reviewed changes
docs/source/stability.rst Outdated Show resolved Hide resolved
Borda and others added 3 commits July 20, 2022 11:17
@Borda @akihironitta
minor
c7c2dbf 
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
rename experimental -> to_review
817a1b8
Merge branch 'experiment_flag' of github.com:Lightning-AI/lightning-b…
623f06f 
…olts into experiment_flag
@otaj otaj changed the title Experiment flag to_review flag Jul 20, 2022
@otaj
Copy link
Contributor Author

otaj commented Jul 20, 2022

I've decided to rename flag experimental to to_review since most of these features are not necessarily experimental, however all of them are to review

@otaj otaj merged commit cf670cd into master Jul 20, 2022
@otaj otaj deleted the experiment_flag branch July 20, 2022 13:16
@Borda
Copy link
Member

Borda commented Jul 20, 2022

I've decided to rename flag experimental to to_review

well, would be fine after this change reset review... :/

@otaj otaj mentioned this pull request Jul 20, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@akihironitta akihironitta akihironitta approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

Assignees
No one assigned
Labels
callback datamodule Anything related to datamodules documentation Improvements or additions to documentation model ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@otaj @Borda @akihironitta