Integration of lightning_utilties function into flash
#1457
Conversation
uakarsh
requested review from
ethanwharris,
Borda,
tchaton,
justusschock,
krshrimali and
kaushikb11
as code owners
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
I can usually commit to the branch, but I'm leaving these as suggestions as I would like if you also get to accept the changes I suggest. :) The flake8 needs some attention: https://github.com/Lightning-AI/lightning-flash/actions/runs/3072640704/jobs/4964256186, I suggested for the 2 that I could, but you'll have to remove find_spec import from flash/core/utilities/imports.py file as that import is also unused.
In case you don't have time, don't worry about it - let us know and I'll take it from here. 🔥
Co-authored-by: Kushashwa Ravi Shrimali <kushashwaravishrimali@gmail.com>
for more information, see https://pre-commit.ci
1. Kept the import name of "module_available" and "compare_version" as it is 2. Removed the unused imports in the apply_func 3. "is_overridden" is used for "_is_overridden" in apply_func.py file
for more information, see https://pre-commit.ci
Codecov ReportBase: 81.27% // Head: 92.33% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1457 +/- ##
===========================================
+ Coverage 81.27% 92.33% +11.06%
===========================================
Files 291 291
Lines 13197 13171 -26
===========================================
+ Hits 10726 12162 +1436
+ Misses 2471 1009 -1462
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Hey @uakarsh - Thank you so much! We are closing in, just left a comment to replace _is_overridden with is_overridden from lightning_utilities package. In case I wasn't clear enough in the review comment, or you have any queries, let me know - and I can push those changes for you.
Just one more step, and we are done. 🚀
|
Thanks for giving me this opportunity @krshrimali. I would be more than happy to solve more issues. I guess I am surely having fun trying to use the tools of Lightning AI, especially for experiments and Kaggle. Just a thought, currently in research, multimodality is something, which is used for obtaining good performance. So, how about introducing a multi-modal framework? I am not sure, how to go, but maybe something like using Image + the text inside the Image + Question for Answering. Do let me know your thoughts. |
What does this PR do?
Fixes #1452
Currently, I was able to only find the changes in
flash/core/utilities/imports.pyBefore submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
CC:
@carmocca @krshrimali