Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity check for primitive inplace copy operator #265

Closed
kiya00 opened this issue Apr 24, 2024 · 2 comments
Closed

Add sanity check for primitive inplace copy operator #265

kiya00 opened this issue Apr 24, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@kiya00
Copy link
Collaborator

kiya00 commented Apr 24, 2024

馃殌 Feature

Add a sanity check to ensure the copy_to argument of prims.copy_ is not used as input for any of its subsequent operators

Motivation

Nvfuser's fd.add_output(output, input) API has the rule "do not use the input after it has been updated". We need the same sanity check for prims.copy_(copy_from, copy_to).

cc: @IvanYashchuk @jjsjann123

@kiya00 kiya00 added the enhancement New feature or request label Apr 24, 2024
@kiya00 kiya00 self-assigned this Apr 24, 2024
@jjsjann123
Copy link
Collaborator

wondering if this is part of #145 , or just a simple patch to catch the obvious issues?

@kiya00
Copy link
Collaborator Author

kiya00 commented Apr 24, 2024

wondering if this is part of #145 , or just a simple patch to catch the obvious issues?

I think that's a simple patch and could be removed when the full inplace analysis is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants