Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TensorBase.gather #267

Closed
Tracked by #266
athitten opened this issue Apr 24, 2024 · 3 comments · Fixed by #373
Closed
Tracked by #266

Implement TensorBase.gather #267

athitten opened this issue Apr 24, 2024 · 3 comments · Fixed by #373
Assignees
@rdspring1
Labels
enhancement New feature or request nemo Issues needed to support NVIDIA NeMo models. operators

Comments

@athitten
Copy link

athitten commented Apr 24, 2024 •
edited by github-actions bot
Loading

🚀 Feature

Implement TensorBase.gather

Motivation

NeMo Stable Diffusion

cc @apaz-cli @tfogal
@athitten athitten added the enhancement New feature or request label Apr 24, 2024
@athitten athitten mentioned this issue Apr 24, 2024
Open
10 tasks
@tfogal tfogal added nemo Issues needed to support NVIDIA NeMo models. triage review labels Apr 29, 2024
@mruberry
Copy link
Collaborator

mruberry commented May 6, 2024

triage review — @rdspring1 is this issue out of date, or does the method variant of gather need to be implemented, too?

@rdspring1
Copy link
Collaborator

gather is implemented at https://github.com/Lightning-AI/lightning-thunder/blob/main/thunder/torch/__init__.py#L1988.
Should I enable the is_method option for gather and scatter_add?

@mruberry
Copy link
Collaborator

mruberry commented May 6, 2024

gather is implemented at main/thunder/torch/init.py#L1988. Should I enable the is_method option for gather and scatter_add?

That'd be great!

@rdspring1 rdspring1 mentioned this issue May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdspring1 rdspring1

Labels
enhancement New feature or request nemo Issues needed to support NVIDIA NeMo models. operators
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable is_method for gather and scatter_add rdspring1/lightning-thunder
4 participants
@tfogal @rdspring1 @mruberry @athitten