Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NeMo StableDiffusion network #266

Open
2 of 10 tasks
athitten opened this issue Apr 24, 2024 · 3 comments
Open
2 of 10 tasks

Support NeMo StableDiffusion network #266

athitten opened this issue Apr 24, 2024 · 3 comments
Labels
enhancement New feature or request nemo Issues needed to support NVIDIA NeMo models.

Comments

@athitten
Copy link

athitten commented Apr 24, 2024

馃殌 Feature

NeMo's "MegatronLatentDiffusion" model implements Stable Diffusion

Initial examine:

Found 37 distinct operations, of which 30 (81.1%) are supported

Motivation

Pitch

Work items

cc @tfogal

@athitten athitten added the enhancement New feature or request label Apr 24, 2024
@jjsjann123
Copy link
Collaborator

Test memory use of NeMo model with out-of-place add instead of the in-place variant

Wondering how we are going to evaluate this one.
i.e. if we are just using eager mode for the time being, an inplace version does save memory footprint, but that might not translate to a compiled program. Since we might have a chance to fuse out-of-place operation.

@tfogal
Copy link
Collaborator

tfogal commented Apr 24, 2024

Test memory use of NeMo model with out-of-place add instead of the in-place variant

Wondering how we are going to evaluate this one. i.e. if we are just using eager mode for the time being, an inplace version does save memory footprint, but that might not translate to a compiled program. Since we might have a chance to fuse out-of-place operation.

Yeah, it's definitely not an apples-to-apples comparison.

But actually that's not the comparison we're interested in here. Here we'd want to evaluate NeMo alone (i.e. w/o thunder) using in-place ops vs. NeMo alone using out-of-place ops.

While we can always modify any network to use Thunder (and this is the approach I would recommend to most users!), NeMo isn't going to adopt Thunder instantly. First we need to show some value to NeMo.

Until then, the NeMo team is happy to consider changes that make networks more amenable to Thunder, but only if they improve or at least do not regress non-Thunder-based use cases.

Does that make help/make sense?

@jjsjann123
Copy link
Collaborator

Until then, the NeMo team is happy to consider changes that make networks more amenable to Thunder, but only if they improve or at least do not regress non-Thunder-based use cases.

Got'ya. That makes sense. I guess that's also why the last item doesn't have a corresponding thunder issue. Sorry for the noise.

@tfogal tfogal added the nemo Issues needed to support NVIDIA NeMo models. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nemo Issues needed to support NVIDIA NeMo models.
Projects
None yet
Development

No branches or pull requests

4 participants