Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement _VariableFunctionsClass.randint of torch #269

Open
Tracked by #266
athitten opened this issue Apr 24, 2024 · 2 comments
Open
Tracked by #266

Implement _VariableFunctionsClass.randint of torch #269

athitten opened this issue Apr 24, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers nemo Issues needed to support NVIDIA NeMo models.

Comments

@athitten
Copy link

athitten commented Apr 24, 2024

🚀 Feature

Implement _VariableFunctionsClass.randint

Motivation

NeMo Stable Diffusion

cc @tfogal

@athitten athitten added the enhancement New feature or request label Apr 24, 2024
@tfogal tfogal added nemo Issues needed to support NVIDIA NeMo models. triage review labels Apr 29, 2024
@tfogal
Copy link
Collaborator

tfogal commented May 1, 2024

triage team: what guarantees do we need to provide w.r.t. the generated random numbers? i.e. do we need to match torch exactly, match the same distribution, merely respect the low/high parameters?

NeMo does occasionally use the dtype parameter, and sometimes it's even float32 or similar instead of some integer. We might want to map this an RNG op + a cast.

@mruberry
Copy link
Collaborator

mruberry commented May 6, 2024

triage review — we currently don't require matching anything; we would accept an implementation of randint that calls PyTorch's randint

@mruberry mruberry added good first issue Good for newcomers and removed triage review labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers nemo Issues needed to support NVIDIA NeMo models.
Projects
None yet
Development

No branches or pull requests

3 participants