Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed Tests failing but CI is green #97

Closed
kshitij12345 opened this issue Mar 28, 2024 · 2 comments · Fixed by #99
Closed

Distributed Tests failing but CI is green #97

kshitij12345 opened this issue Mar 28, 2024 · 2 comments · Fixed by #99
Assignees
Labels
bug Something isn't working

Comments

@kshitij12345
Copy link
Collaborator

kshitij12345 commented Mar 28, 2024

On latest main 94c9494, CI flow for distributed shows success https://github.com/Lightning-AI/lightning-thunder/runs/23172744261

But looking at the log, there are a few tests that have failed.

Sample

=================================== FAILURES ===================================
_ CompileDDPTest.test_fsdp_grad_parity_with_without_bucketing_executor_nvfuser_bucketing_block_zero2 _
/usr/local/lib/python3.10/dist-packages/torch/testing/_internal/common_distributed.py:533: in wrapper
    self._join_processes(fn)
/usr/local/lib/python3.10/dist-packages/torch/testing/_internal/common_distributed.py:752: in _join_processes
    self._check_return_codes(elapsed_time)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

Link to log: https://dev.azure.com/Lightning-AI/lightning/_build/results?buildId=196660&view=logs&j=47e66f3c-897a-5428-da11-bf5c7745762e&t=97be8351-284a-5dba-49eb-f9fe7c3ed1a2&l=811

cc @Borda

@kshitij12345 kshitij12345 added bug Something isn't working ci labels Mar 28, 2024
@kshitij12345
Copy link
Collaborator Author

Raw Log (in case the CI logs are cleaned): log.txt

@Borda Borda self-assigned this Mar 28, 2024
@Borda
Copy link
Member

Borda commented Mar 28, 2024

Raw Log (in case the CI logs are cleaned): log.txt

so CI is fixed in #99 but probably we would also need to fix the issue... 🤔

@Borda Borda closed this as completed in #99 Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants