Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix not failing step if tests failed #99

Merged
merged 2 commits into from
Mar 29, 2024
Merged

ci: fix not failing step if tests failed #99

merged 2 commits into from
Mar 29, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 28, 2024 •
edited
Loading

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #97 after #9

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the ci label Mar 28, 2024
@Borda Borda mentioned this pull request Mar 28, 2024
Closed
t-vi
t-vi approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Borda

@Borda
Copy link
Member Author

Borda commented Mar 29, 2024

Merging this as it prevents from merging anything else then needed fixes 🎏

@Borda Borda merged commit 78401af into main Mar 29, 2024
33 of 37 checks passed
@Borda Borda deleted the ci/set-e branch March 29, 2024 07:29
@Borda
Copy link
Member Author

Borda commented Mar 29, 2024 •
edited
Loading

so the failure started between 0f03314 and 37129cf so it mean it is unrelated to our codebase... also I do not see any requirement chnaged

@Borda Borda mentioned this pull request Mar 29, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@carmocca carmocca Awaiting requested review from carmocca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distributed Tests failing but CI is green
2 participants
@Borda @t-vi