Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topk: backward implementation #118

Merged
merged 3 commits into from Apr 3, 2024
Merged

topk: backward implementation #118

merged 3 commits into from Apr 3, 2024

Conversation

nikitaved
Copy link
Contributor

@nikitaved nikitaved commented Apr 2, 2024 •
edited

As per title. Required to unblock testing of some variants of litgpt models.

t-vi
t-vi approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nikitaved !

@nikitaved nikitaved mentioned this pull request Apr 2, 2024
Open
@t-vi t-vi enabled auto-merge (squash) April 2, 2024 11:38
@nikitaved nikitaved mentioned this pull request Apr 2, 2024
Open
@nikitaved nikitaved force-pushed the nikitaved/topk_backward branch 4 times, most recently from c7eef87 to cb2b8e2 Compare April 2, 2024 14:11
@nikitaved
Copy link
Contributor Author

@t-vi , the failures seem to be unrelated. Let me know if you beg to differ, otherwise it is good to go.

@nikitaved
Copy link
Contributor Author

I cannot reproduce OOMs locally

@nikitaved nikitaved force-pushed the nikitaved/topk_backward branch 2 times, most recently from d39a969 to f19a511 Compare April 3, 2024 11:42
nikitaved
nikitaved commented Apr 3, 2024
View reviewed changes
thunder/tests/test_grad.py Outdated Show resolved Hide resolved
@nikitaved nikitaved force-pushed the nikitaved/topk_backward branch 2 times, most recently from d618bac to b91d2dd Compare April 3, 2024 12:02
@t-vi t-vi merged commit 26d6255 into main Apr 3, 2024
39 checks passed
@t-vi t-vi deleted the nikitaved/topk_backward branch April 3, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@robieta robieta Awaiting requested review from robieta robieta is a code owner

@carmocca carmocca Awaiting requested review from carmocca carmocca is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nikitaved @carmocca @t-vi