Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for torch.Tensor.unfold #136

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Added support for torch.Tensor.unfold #136

merged 5 commits into from
Apr 8, 2024

Conversation

riccardofelluga
Copy link
Collaborator

@riccardofelluga riccardofelluga commented Apr 5, 2024 •
edited
Loading

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This PR adds support for torch.Tensor.unfold

Did you have fun?

Oh yes! 🚀

cc @apaz-cli

nikitaved
nikitaved reviewed Apr 5, 2024
View reviewed changes
thunder/core/prims.py Outdated Show resolved Hide resolved
nikitaved
nikitaved reviewed Apr 5, 2024
View reviewed changes
thunder/tests/opinfos.py Outdated Show resolved Hide resolved
nikitaved
nikitaved approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@nikitaved nikitaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @riccardofelluga !

@IvanYashchuk IvanYashchuk enabled auto-merge (squash) April 8, 2024 09:37
@IvanYashchuk
Copy link
Collaborator

Codeowner approval is required to merge.
@t-vi, @carmocca

carmocca
carmocca approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IvanYashchuk IvanYashchuk merged commit 393828f into main Apr 8, 2024
39 checks passed
@IvanYashchuk IvanYashchuk deleted the unfold-operator branch April 8, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitaved nikitaved nikitaved approved these changes

@carmocca carmocca carmocca approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@robieta robieta Awaiting requested review from robieta

@t-vi t-vi Awaiting requested review from t-vi t-vi is a code owner

Assignees
No one assigned
Labels
operators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@riccardofelluga @IvanYashchuk @nikitaved @carmocca