-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable matmul for nvFuser #207
Conversation
Do you mind trying this in your branch? Note: you might want to remove the I'm getting It's also failing with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry this falls off my radar.
cc'ing @IvanYashchuk regarding the matmul checker rejection
vs throwing an error. It makes more sense to just reject the matmul instead of throwing an error with out-dated nvfuser version (our stable release is still using older nvfuser version).
Meanwhile, stamping to merge!
We can revisit Ivan's suggestion is he has a strong opinion on the exception, we can throw a warning if you are just concerned about silently running with out-dated library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Priya2698 @IvanYashchuk @jjsjann123
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
What does this PR do?
Enables matmul in nvFuser. Part of resolving NVIDIA/Fuser#2053