Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: compile TE #209

Closed
wants to merge 23 commits into from
Closed

docker: compile TE #209

wants to merge 23 commits into from

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 17, 2024 •
edited by github-actions bot
Loading

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #196

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@Borda Borda changed the title docker: compile TE docker: refactor & compile TE Apr 17, 2024
@Borda Borda marked this pull request as ready for review April 17, 2024 12:27
@Borda
Copy link
Member Author

Borda commented Apr 20, 2024

any hint on how to set the CUDNN path? https://dev.azure.com/Lightning-AI/lightning/_build/results?buildId=199551&view=log[…]c2d0-7f7286b3996d&t=3cfa2d55-62a7-5f49-36ea-726d310411c0&l=204

@Borda Borda mentioned this pull request Apr 22, 2024
Merged
4 tasks
@Borda Borda changed the title docker: refactor & compile TE docker: compile TE Apr 22, 2024
@Borda Borda marked this pull request as draft April 22, 2024 08:14
@Borda
Copy link
Member Author

Borda commented Apr 22, 2024

pending on #243

@github-actions github-actions bot removed the install label Apr 22, 2024
@Borda Borda marked this pull request as ready for review April 22, 2024 20:43
@IvanYashchuk
Copy link
Collaborator

Should git+https://github.com/NVIDIA/TransformerEngine.git@stable be added to the devel.txt requirements?
https://github.com/NVIDIA/TransformerEngine?tab=readme-ov-file#pip

@IvanYashchuk IvanYashchuk mentioned this pull request Apr 24, 2024
Merged
@Borda
Copy link
Member Author

Borda commented Apr 25, 2024

Should git+https://github.com/NVIDIA/TransformerEngine.git@stable be added to the devel.txt requirements? NVIDIA/TransformerEngine#pip

well, in another form, it could be but not be re-installed once it exists
anyway, I still have some difficulty in compiling/installing it

@kshitij12345
Copy link
Collaborator

I think we should pursue PR this once we have GPU with compute capability 8.9 or above.
See comment: #196 (comment)

@Borda Borda marked this pull request as draft April 25, 2024 15:42
@lantiga lantiga mentioned this pull request May 30, 2024
Open
@lantiga lantiga added the later label May 30, 2024
@lantiga
Copy link
Collaborator

lantiga commented May 30, 2024

Closing for now, labeled as "later"

@lantiga lantiga closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@t-vi t-vi Awaiting requested review from t-vi t-vi is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@mruberry mruberry Awaiting requested review from mruberry

@robieta robieta Awaiting requested review from robieta

Assignees
No one assigned
Labels
docker later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ci] : We should add a CI flow with TransformerEngine installed so that we can run the relevant tests.
4 participants
@Borda @IvanYashchuk @kshitij12345 @lantiga