Use runtime value of NumberProxy if it is produced by an operator (#231) #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiya00
requested review from
mruberry,
lantiga,
robieta,
t-vi and
carmocca
as code owners
for more information, see https://pre-commit.ci
|
Could you please explain in the issue why is it a problem and what do you want to achieve? |
jjsjann123
reviewed
Apr 22, 2024
8 tasks
|
@jjsjann123, with this PR your example script from #541 (comment) works! |
IvanYashchuk
requested changes
Jun 11, 2024
There was a problem hiding this comment.
@kiya00, I have reopened this pull request because I think this is the correct fix for the bugs we have. I'm sorry that I missed it somehow.
Could you please add this example #541 (comment) as a test case.
jjsjann123
approved these changes
Jun 11, 2024
|
Hi @IvanYashchuk , I have added the test, please take another look~ |
IvanYashchuk
approved these changes
Jun 12, 2024
|
@t-vi, could you please merge this PR? |
3 tasks
t-vi
approved these changes
Jun 13, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Try to fix #231.
The changes in this PR go through all the NumberProxy in
saved_for_backward, replace it with thevaluein NumberProxy if it has no producer in the forward trace, otherwise keep the NumberProxy