New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support `nan_to_num` #249

Merged

mruberry merged 17 commits into Lightning-AI:main from k223kim:k223kim/add_nan_to_num

Apr 24, 2024

Contributor

k223kim commented Apr 22, 2024 •

edited

Loading

Before submitting

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contributor guideline, Pull Request section?
Did you make sure to update the docs?
Did you write any new necessary tests?

What does this PR do?

Fixes #176.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

One of the best part of my day!


          feat: implemented nan_to_num with test case

236dd78

mruberry requested a review from nikitaved

April 22, 2024 19:40

mruberry reviewed

View reviewed changes

thunder/tests/opinfos.py Show resolved Hide resolved

mruberry reviewed

View reviewed changes

thunder/tests/opinfos.py Outdated Show resolved Hide resolved

mruberry reviewed

View reviewed changes

thunder/tests/opinfos.py Show resolved Hide resolved

mruberry reviewed

View reviewed changes

thunder/torch/__init__.py Show resolved Hide resolved

mruberry reviewed

View reviewed changes

thunder/tests/opinfos.py Outdated Show resolved Hide resolved

mruberry reviewed

View reviewed changes

Collaborator

mruberry left a comment

Great start, @k223kim! I made some comments for you review

mruberry reviewed

View reviewed changes

Collaborator

mruberry left a comment

Great start, @k223kim! I made some comments for you review

k223kim and others added 4 commits

April 23, 2024 08:19


          feat: updated test case for nan_to_num to test nans and floats properly

cc0ef39


          Revert "feat: updated test case for nan_to_num to test nans and float…

0a12e09

…s properly"

This reverts commit cc0ef39.


          feat: updated test case for nan_to_num to test nan and inf properly

9af1079


          Merge branch 'main' into k223kim/add_nan_to_num

64d423d

k223kim marked this pull request as ready for review

April 22, 2024 23:57

k223kim requested review from lantiga, robieta, t-vi and carmocca as code owners

April 22, 2024 23:57

k223kim and others added 2 commits

April 23, 2024 09:01


          feat: small fix in test case

cdcc97b


          Merge branch 'main' into k223kim/add_nan_to_num

74a27fa

nikitaved reviewed

View reviewed changes

thunder/torch/__init__.py Outdated Show resolved Hide resolved

nikitaved reviewed

View reviewed changes

thunder/torch/__init__.py Outdated Show resolved Hide resolved

k223kim and others added 4 commits

April 23, 2024 18:55


          feat: updated nan_to_num to handle overflow

bfb9609


          [pre-commit.ci] auto fixes from pre-commit.com hooks

0742e36

for more information, see https://pre-commit.ci


          feat: updated to resemble a.clone()

ec93c5c


          [pre-commit.ci] auto fixes from pre-commit.com hooks

60d708f

for more information, see https://pre-commit.ci

nikitaved reviewed

View reviewed changes

thunder/torch/__init__.py Outdated Show resolved Hide resolved

Kaeun Kim and others added 2 commits

April 23, 2024 20:36


          feat: quick fix

350526d


          Merge branch 'main' into k223kim/add_nan_to_num

71e91d4

mruberry reviewed

View reviewed changes

thunder/tests/opinfos.py Outdated Show resolved Hide resolved

mruberry reviewed

View reviewed changes

thunder/tests/opinfos.py Outdated Show resolved Hide resolved

mruberry reviewed

View reviewed changes

thunder/torch/__init__.py Outdated Show resolved Hide resolved


          feat: added docstring for nan_to_num with additional test cases

e6b9be7

mruberry reviewed

View reviewed changes

thunder/tests/opinfos.py Outdated Show resolved Hide resolved


          feat: quick fix2

4c4763d

mruberry reviewed

View reviewed changes

thunder/torch/__init__.py Outdated Show resolved Hide resolved

mruberry reviewed

View reviewed changes

Collaborator

mruberry left a comment

Looks good, @k223kim! I added one last comment about a small error

k223kim and others added 2 commits

April 25, 2024 00:38


          feat: added inline helper function

37e7042


          Merge branch 'main' into k223kim/add_nan_to_num

4f0c222

mruberry approved these changes

View reviewed changes

Collaborator

mruberry left a comment

Collaborator

mruberry commented Apr 24, 2024

Cool! Thanks @k223kim!

mruberry merged commit 0e0f305 into Lightning-AI:main

39 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nikitaved nikitaved left review comments

mruberry mruberry approved these changes

lantiga Awaiting requested review from lantiga lantiga is a code owner

robieta Awaiting requested review from robieta

t-vi Awaiting requested review from t-vi t-vi is a code owner

carmocca Awaiting requested review from carmocca