Minor Readme cosmetics #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-vi
approved these changes
Mar 21, 2024
lantiga
approved these changes
Mar 21, 2024
README.md
Outdated
| @@ -119,11 +119,11 @@ print(result) | |||
|
|
|||
| The compiled function `jfoo` takes and returns PyTorch tensors, just like the original function, so modules and functions compiled by Thunder can be used as part of larger PyTorch programs. | |||
|
|
|||
| ## Train models | |||
| ## Model training with Thunder | |||
There was a problem hiding this comment.
Let's keep Train models as the title
There was a problem hiding this comment.
I don't know where the "Train models" came from. In my copy it said "Running training" hence the change. But I like "Train models" even better than "Model training with models"
|
Thank you @rasbt |
Borda
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just reading through the README and noticed a few points and thought making a quick PR doesn't hurt :)