Implement clone() #429
Implement clone() #429
Conversation
Fixes #342.
|
The failures are distributed notebook flakiness; unrelated, so marking ready for review. I didn't understand the #342 comment about not making this a symbol. Without the |
tfogal
requested review from
mruberry,
lantiga,
robieta,
t-vi and
carmocca
as code owners
|
The test failures are for distributed things: |
|
triage review — just |
|
The failures are just the distributed tests failing, issue #432. This is ready for re-review / merging. |
Since we're incorrectly returning an alias, modifications to the returned tensor will show up in the original tensor. Add a test that demonstrates this, which should remind us to revisit this implementation once we properly implement functionalization. Thanks Luca Antiga for the idea. Also, it turns out PyTorch fixed an issue with their sparse_coo in the interim and so that test started passing. So this also removes the sparse test's xfail.
for more information, see https://pre-commit.ci
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Fixes #342.
What does this PR do?
Fixes #342
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Always ;-)