pad: support alternate value types.
#459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyTorch actually allows the `value` argument to have a different type than the input type, as long as the type of `value` is convertible to the type of `input`. This contradicts the documentation at: https://pytorch.org/docs/stable/generated/torch.nn.functional.pad.html which indicates that the padding value, if specified, must be a float. Fixes #458.
mruberry
reviewed
May 28, 2024
mruberry
reviewed
May 28, 2024
mruberry
reviewed
May 28, 2024
tfogal
force-pushed
the
tfogal/pad-value-type
branch
from
b597d8a
to
cf48054
Compare
for more information, see https://pre-commit.ci
jjsjann123
approved these changes
May 28, 2024
crcrpar
pushed a commit
that referenced
this pull request
May 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch actually allows the
valueargument to have a different type than the input type, as long as the type ofvalueis convertible to the type ofinput. This contradicts the documentation which indicates that the padding value, if specified, must be a float. 馃しFixes #458.
cc @tfogal