Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[distributed][Tensor Parallelism] Improve type annotation #519

Merged
merged 3 commits into from
Jun 4, 2024
Merged

[distributed][Tensor Parallelism] Improve type annotation #519

merged 3 commits into from
Jun 4, 2024

Conversation

crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Jun 4, 2024

No description provided.

@crcrpar
import guard with torch.distributed availability
4ed6433 
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
@crcrpar
Callable -> ComputationTraceTransformVisitorForTensorParallel
1abbac5 
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
@crcrpar
import cleanup
60b49c5 
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
t-vi
t-vi approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @crcrpar

@t-vi t-vi merged commit a5d892d into main Jun 4, 2024
37 checks passed
@t-vi t-vi deleted the crpa/tensor-parallel_type-annottion branch June 4, 2024 09:17
@crcrpar crcrpar added the tensor parallel distributed - tensor parallel label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@robieta robieta Awaiting requested review from robieta

Assignees
No one assigned
Labels
tensor parallel distributed - tensor parallel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crcrpar @t-vi