Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for timer_and_memory_stats in benchmarks/targets.py #522

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Add docs for timer_and_memory_stats in benchmarks/targets.py #522

merged 2 commits into from
Jun 4, 2024

Conversation

IvanYashchuk
Copy link
Collaborator

@IvanYashchuk IvanYashchuk commented Jun 4, 2024 •
edited by github-actions bot
Loading

Added a bit of documentation for the timer wrapper added in #513.

cc @crcrpar

@IvanYashchuk IvanYashchuk requested a review from kiya00 June 4, 2024 11:58
t-vi
t-vi approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who would not love docs. Thank you @IvanYashchuk

kiya00
kiya00 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@kiya00 kiya00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for adding the docs! @IvanYashchuk

@t-vi t-vi merged commit 6db4710 into main Jun 4, 2024
37 of 38 checks passed
@t-vi t-vi deleted the docs-timer-memory branch June 4, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiya00 kiya00 kiya00 approved these changes

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@robieta robieta Awaiting requested review from robieta

Assignees
No one assigned
Labels
benchmarking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IvanYashchuk @kiya00 @t-vi