Allocate dQ, dK, and dV as a catted tensor to save a downstream cat in nvFuser. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wujingyue
requested review from
mruberry,
lantiga,
robieta and
t-vi
as code owners
Co-authored-by: Masaki Kozuki <mkozuki@nvidia.com>
wujingyue
commented
Mar 25, 2024
t-vi
approved these changes
Mar 25, 2024
|
Hey @vedaanta-nvidia, are you interested in reviewing this before I merge? |
Hey Vedaanta, do you have more comments before I merge? |
vedaanta
reviewed
Mar 27, 2024
vedaanta
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NVIDIA/Fuser#1768.
The description on the added compile option explains what this optimization does.
This optimization is disabled by default for now. I'll try to enable it by default or even always after #35 is merged and bookend is disabled by default.