topk: add as a primitive #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitaved
requested review from
mruberry,
lantiga,
robieta,
t-vi and
carmocca
as code owners
nikitaved
force-pushed
the
nikitaved/topk
branch
3 times, most recently
from
a937c2b
to
4ffb973
Compare
|
OK, so the issues popped after the rebase... |
nikitaved
force-pushed
the
nikitaved/topk
branch
from
00acba4
to
4d1c374
Compare
nikitaved
force-pushed
the
nikitaved/topk
branch
from
4d1c374
to
f5e83d5
Compare
for more information, see https://pre-commit.ci
|
Thank you @nikitaved @carmocca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title. The underlying PyTorch implementation is not trivial, so it is best to model this op as a prim.
There are still some to be done follow-ups to make the op functional and useful. These are:
indicesandvaluesare accessible in the jit. Currently, these are not supported and these could be accessed only with indices.