Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only import PostLocalSGD related modules when it's needed #10359

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Nov 4, 2021

What does this PR do?

Partially Fixes #10348

Does your PR introduce any breaking changes? If yes, please list them.

DistributedOptimizer, PostLocalSGDOptimizer, ZeroRedundancyOptimizer and torch.distributed.algorithms modules only needed when isinstance(self._ddp_comm_state, post_localSGD.PostLocalSGDState), move the import into _reinit_optimizers_with_post_localSGD() where these modules are used.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@four4fish four4fish marked this pull request as draft November 4, 2021 19:04
@four4fish four4fish marked this pull request as ready for review November 4, 2021 20:46
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #10359 (1a6dfbf) into master (939a861) will decrease coverage by 4%.
The diff coverage is 29%.

❗ Current head 1a6dfbf differs from pull request most recent head 9b64c54. Consider uploading reports for the commit 9b64c54 to get more accurate results

@@           Coverage Diff            @@
##           master   #10359    +/-   ##
========================================
- Coverage      93%      89%    -4%     
========================================
  Files         181      181            
  Lines       16471    16471            
========================================
- Hits        15245    14611   -634     
- Misses       1226     1860   +634     

@four4fish four4fish added the distributed Generic distributed-related topic label Nov 5, 2021
pytorch_lightning/plugins/training_type/ddp.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 5, 2021
@awaelchli awaelchli added this to the 1.5.x milestone Nov 5, 2021
@awaelchli awaelchli added the bug Something isn't working label Nov 5, 2021
@justusschock justusschock enabled auto-merge (squash) November 5, 2021 09:24
@justusschock justusschock merged commit bdc24e5 into Lightning-AI:master Nov 8, 2021
awaelchli pushed a commit that referenced this pull request Nov 8, 2021
* Only import PostLocalSGD related modules when it's needed

* Only import PostLocalSGD related modules when it's needed

* Only import PostLocalSGD related modules when it's needed
awaelchli pushed a commit that referenced this pull request Nov 9, 2021
* Only import PostLocalSGD related modules when it's needed

* Only import PostLocalSGD related modules when it's needed

* Only import PostLocalSGD related modules when it's needed
lexierule pushed a commit that referenced this pull request Nov 9, 2021
* Only import PostLocalSGD related modules when it's needed

* Only import PostLocalSGD related modules when it's needed

* Only import PostLocalSGD related modules when it's needed
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
…AI#10359)

* Only import PostLocalSGD related modules when it's needed

* Only import PostLocalSGD related modules when it's needed

* Only import PostLocalSGD related modules when it's needed
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distributed Generic distributed-related topic ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module 'torch.distributed' has no attribute 'ProcessGroup' when importing PyTorch Lightning
6 participants