Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated prepare_data_per_node in Trainer #12536

Merged
merged 17 commits into from Apr 2, 2022

Conversation

yhl48
Copy link
Contributor

@yhl48 yhl48 commented Mar 30, 2022

What does this PR do?

Part of #12521

resolves #8958

Does your PR introduce any breaking changes? If yes, please list them.

Remove deprecated prepare_data_per_node in Trainer

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@krshrimali krshrimali added refactor breaking change Includes a breaking change deprecation Includes a deprecation labels Mar 31, 2022
@krshrimali krshrimali changed the title Remove prepare_data_per_node in trainer Remove deprecated prepare_data_per_node in trainer Mar 31, 2022
@krshrimali krshrimali changed the title Remove deprecated prepare_data_per_node in trainer Remove deprecated prepare_data_per_node in Trainer Mar 31, 2022
@krshrimali krshrimali removed the deprecation Includes a deprecation label Mar 31, 2022
@yhl48
Copy link
Contributor Author

yhl48 commented Mar 31, 2022

Not sure if the doc here needs changing? Would appreciate any advice here, thanks.
https://github.com/PyTorchLightning/pytorch-lightning/blob/cf65ca25b0230df89eec77c218c5e928c8141840/pytorch_lightning/core/hooks.py#L364

CHANGELOG.md Outdated Show resolved Hide resolved
@rohitgr7
Copy link
Contributor

Not sure if the doc here needs changing? Would appreciate any advice here, thanks.

https://github.com/PyTorchLightning/pytorch-lightning/blob/cf65ca25b0230df89eec77c218c5e928c8141840/pytorch_lightning/core/hooks.py#L364

this should be good:

In DDP ``prepare_data`` can be called in two ways (using ``prepare_data_per_node``):

since there is already a reference for it right below :)

@yhl48 yhl48 requested a review from ananthsub as a code owner March 31, 2022 16:54
@mergify mergify bot added the ready PRs ready to be merged label Mar 31, 2022
@Borda Borda enabled auto-merge (squash) March 31, 2022 17:09
CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/core/hooks.py Outdated Show resolved Hide resolved
Co-authored-by: ananthsub <2382532+ananthsub@users.noreply.github.com>
@Borda Borda merged commit 56a3485 into Lightning-AI:master Apr 2, 2022
@yhl48 yhl48 deleted the prepare_data_per_node_removal branch April 3, 2022 10:37
@akihironitta akihironitta added this to the 1.7 milestone Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged refactor trainer: argument
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants