Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ShardedGradScaler should only be set for FP16 #12915

Merged
merged 4 commits into from
Apr 28, 2022
Merged

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Apr 28, 2022

What does this PR do?

Closes #12914

When running with sharded training + bf16, I noticed that the ShardedGradScaler was being passed. This is incorrect as BF16 does not require any scaling logic. Fixed this and added a unit test!

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @SeanNaren @awaelchli @rohitgr7 @akihironitta @carmocca @justusschock

@carmocca carmocca added bug Something isn't working strategy: fairscale sharded (removed) Sharded Data Parallel precision: amp Automatic Mixed Precision labels Apr 28, 2022
@mergify mergify bot added the ready PRs ready to be merged label Apr 28, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@carmocca carmocca merged commit bcbd9c3 into master Apr 28, 2022
@carmocca carmocca deleted the fix/sharded_scaler branch April 28, 2022 15:44
carmocca added a commit that referenced this pull request Apr 28, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request May 3, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working precision: amp Automatic Mixed Precision ready PRs ready to be merged strategy: fairscale sharded (removed) Sharded Data Parallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShardedGradScaler should not be used in BF16
6 participants